Skip to content

bump linter v2.5.0 -> v2.11.4 + fixes#494

Merged
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
gauron99:push-onrkkzmyuxkm
Apr 28, 2026
Merged

bump linter v2.5.0 -> v2.11.4 + fixes#494
knative-prow[bot] merged 1 commit into
knative-extensions:mainfrom
gauron99:push-onrkkzmyuxkm

Conversation

@gauron99
Copy link
Copy Markdown
Contributor

@gauron99 gauron99 commented Apr 28, 2026 •
edited
Loading

fixes the CI for release

  • bump linter in build/Magefile.go to run with go 1.26
  • subsequently fix an error because of a newly introduced linter rule with the newer version

@knative-prow knative-prow Bot requested review from cardil and dsimansk April 28, 2026 06:50
@knative-prow knative-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (b29e7ed) to head (0088110).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files          52       52           
  Lines        1408     1408           
=======================================
  Hits          952      952           
  Misses        386      386           
  Partials       70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gauron99 gauron99 force-pushed the push-onrkkzmyuxkm branch from cecf447 to 0088110 Compare April 28, 2026 08:14
@gauron99 gauron99 changed the title bump linter v2.5.0 -> v2.11.4 bump linter v2.5.0 -> v2.11.4 + fixes Apr 28, 2026
@dprotaso
Copy link
Copy Markdown
Contributor

dprotaso commented Apr 28, 2026

/lgtm
/approve

@knative-prow knative-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2026
@knative-prow
Copy link
Copy Markdown

knative-prow Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
dprotaso
dprotaso reviewed Apr 28, 2026
View reviewed changes
Comment thread test/e2e/ics_send.go
}); err != nil {
t.Fatal(err, "\n\nExecution log: "+
path.Join(cacheDir, "last-exec.log.jsonl"))
filepath.Join(cacheDir, "last-exec.log.jsonl"))
Copy link
Copy Markdown
Contributor

@dprotaso dprotaso Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a filepath.CLean here?

Copy link
Copy Markdown
Contributor Author

@gauron99 gauron99 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its cleaned few lines up when the cacheDir is being defined

@knative-prow knative-prow Bot merged commit 93695be into knative-extensions:main Apr 28, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dprotaso dprotaso dprotaso left review comments

@cardil cardil Awaiting requested review from cardil

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gauron99 @dprotaso